Issue 2725: mv acquire/release disk actors from DR to libs/storage/core #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
komarevtsev-d
added
large-tests
github-actions
bot
removed
the
ok-to-test
komarevtsev-d
requested changes
Jan 16, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_ut_session.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
vladstepanyuk
commented
Jan 16, 2025
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
previously approved these changes
Jan 16, 2025
sharpeye
reviewed
Jan 16, 2025
| @@ -1,62 +1,60 @@ | |||
| #include "disk_registry_actor.h" | |||
| #include "acquire_release_devices.h" | |||
There was a problem hiding this comment.
а cpp файл не должен называть acquire_release_devices.cpp ?
There was a problem hiding this comment.
переименовал хэдэр в acquire_release_devices_actors.h
и тогда у меня два cpp шника: acquire_devices_actor.cpp и release_devices_actor.cpp, в которых соответственнно реализация акторов с логикой посылки сообщений TAcquireDevicesRequest и TReleaseDevicesRequest
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor.h
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_actor_acquire_release.cpp
Outdated
Show resolved
Hide resolved
komarevtsev-d
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
komarevtsev-d
approved these changes
Jan 20, 2025
komarevtsev-d
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2725 move acquire release disk actors from DR to use it later in volume