issue-2559: background shard stats aggregation shouldn't get stuck in…

… case of GetStorageStats errors from shards (#2650)
ydb-platform · Dec 8, 2024 · f508886 · f508886
1 parent 6271c21
commit f508886
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/cloud/filestore/libs/storage/tablet/tablet_actor_counters.cpp b/cloud/filestore/libs/storage/tablet/tablet_actor_counters.cpp
@@ -915,10 +915,11 @@ void TIndexTabletActor::HandleGetShardStatsCompleted(
 {
     auto* msg = ev->Get();
     const bool isBackgroundRequest = msg->StartedTs.GetValue() == 0;
+    if (isBackgroundRequest) {
+        CachedStatsFetchingInProgress = false;
+    }
     if (!HasError(msg->Error)) {
-        if (isBackgroundRequest) {
-            CachedStatsFetchingInProgress = false;
-        } else {
+        if (!isBackgroundRequest) {
             Metrics.StatFileStore.Update(1, 0, ctx.Now() - msg->StartedTs);
         }
         CachedAggregateStats = std::move(msg->AggregateStats);