Skip to content

Commit

Permalink
use bucket-location param to locate s3 bucket (#442)
Browse files Browse the repository at this point in the history
  • Loading branch information
leftmain authored Feb 14, 2024
1 parent d45e8ab commit d7219c6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ class AcceptanceTestBinaryExecutor(BaseTestBinaryExecutor):

def __init__(self, args, *arguments, **kwargs):
super(AcceptanceTestBinaryExecutor, self).__init__(args, *arguments, **kwargs)
location = args.cluster
if args.profile_name is not None:
location = args.profile_name
location = args.bucket_location or args.profile_name or args.cluster
self._acceptance_test_cmd.extend([
'--url-for-create-image-from-url-test',
f"https://{self._s3_host}/{location}.disk-manager/acceptance-tests/ubuntu-1604-ci-stable"])
Expand Down
7 changes: 7 additions & 0 deletions cloud/disk_manager/test/acceptance/test_runner/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ def parse_args() -> argparse.Namespace:
default=None,
help='url for s3 to store images',
)
acceptance_test_type_parser.add_argument(
'--bucket-location',
type=str,
dest='bucket_location',
default=None,
help='s3 bucket location',
)

# eternal test type stuff
eternal_test_type_parser = subparsers.add_parser(
Expand Down

0 comments on commit d7219c6

Please sign in to comment.