Return pulic error if checkpoint replica was broken during snapshot f…

…illing
ydb-platform · Feb 11, 2025 · 120c4ed · 120c4ed
1 parent 6bfb931
commit 120c4ed
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cloud/disk_manager/internal/pkg/clients/nbs/client.go b/cloud/disk_manager/internal/pkg/clients/nbs/client.go
@@ -381,6 +381,13 @@ func IsGetChangedBlocksNotSupportedError(e error) bool {
 		clientErr.Code == nbs_client.E_NOT_IMPLEMENTED
 }
 
+func IsIOError(e error) bool {
+	clientErr := nbs_client.GetClientError(e)
+
+	return clientErr.Code == nbs_client.E_IO ||
+		clientErr.Code == nbs_client.E_IO_SILENT
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 
 func setupStderrLogger(ctx context.Context) context.Context {

diff --git a/cloud/disk_manager/internal/pkg/services/snapshots/create_snapshot_from_disk_task.go b/cloud/disk_manager/internal/pkg/services/snapshots/create_snapshot_from_disk_task.go
@@ -13,6 +13,7 @@ import (
 	performance_config "github.com/ydb-platform/nbs/cloud/disk_manager/internal/pkg/performance/config"
 	"github.com/ydb-platform/nbs/cloud/disk_manager/internal/pkg/resources"
 	"github.com/ydb-platform/nbs/cloud/disk_manager/internal/pkg/services/snapshots/protos"
+	"github.com/ydb-platform/nbs/cloud/disk_manager/pkg/client/codes"
 	"github.com/ydb-platform/nbs/cloud/tasks"
 	"github.com/ydb-platform/nbs/cloud/tasks/errors"
 	"github.com/ydb-platform/nbs/cloud/tasks/headers"
@@ -123,6 +124,14 @@ func (t *createSnapshotFromDiskTask) run(
 
 	response, err := t.scheduler.WaitTask(ctx, execCtx, taskID)
 	if err != nil {
+		if nbs.IsIOError(err) {
+			return errors.NewDetailedError(err, &errors.ErrorDetails{
+				Code:     codes.Aborted,
+				Message:  "Snapshot creation failed, please retry", // TODO:_ should user know about it?
+				Internal: false,
+			})
+			// TODO:_ public => silent... Are we sure?
+		}
 		return err
 	}