Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some CSS variables #162

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

onlywei
Copy link
Contributor

@onlywei onlywei commented Feb 21, 2024

What has been done

Fixed some CSS variable mistakes

Checklist before requesting a review

  • I have read the contributing doc before submitting this PR.
  • Commit titles correspond to the convention.
  • I have performed a self-review of my code.
  • Tests for the changes have been added (for bug fixes/features).
  • Docs have been added / updated (for bug fixes / features).

Screenshots (if appropriate):

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-international-phone-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:57pm
react-international-phone-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:57pm

@ybrusentsov
Copy link
Owner

@onlywei Thanks for the PR!
PR looks good to me, but it seems like you will still not appear on the contributors list if I merge it right now.
Github does not display you as a commit author:
image

I believe you need to update your git config email value to match your GitHub email, something like this:

git config user.email "[email protected]"

https://stackoverflow.com/questions/28373057/user-name-of-the-github-account-is-not-displayed-as-the-author-of-the-commits.

Or let me know if you don't bother it and I will merge it right away.

@onlywei
Copy link
Contributor Author

onlywei commented Feb 22, 2024

@goveo Thanks for figuring that out. I just did config to use my github email instead of my work email. Then I did git commit --amend --reset-author, followed by a force push to this branch. How does it look now?

@ybrusentsov ybrusentsov merged commit a747396 into ybrusentsov:development Feb 22, 2024
8 checks passed
@ybrusentsov
Copy link
Owner

🎉 This PR is included in version 4.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants