PoC: Guard secret attributes against leaking to the logs V1.0 #1359
+71
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of Concept [superseded]
Problem
Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like
inspect()
are used.Fix
Use a custom
inspect()
method that clones the original object and sanitizes all fields that should not be logged verbatim (replacing each one with a special string<sanitized>
).Related PR
Superseded by PR #1360 which uses
attr_secret
fromYaST2::SecretAttributes
.