Improved city screen queue #12737
Improved city screen queue #12737
Conversation
- moved "buy" button to city info table - removed "add to queue" button - expand icon changed to android defaults - CityStatsTable: big scrollable area, expandable
…cramped portrait - moved priority buttons under the queue - queue is collapsible and shows preview - when expanded, the queue takes available space - collapse stats on cramped portrait - collapsed stats show 2 lines of resources in cramped portrait to reduce width, right aligned - raze button moved close to city button in cramped portrait
…-Queue # Conflicts: # core/src/com/unciv/ui/components/widgets/ExpanderTab.kt # core/src/com/unciv/ui/screens/cityscreen/BuyButtonFactory.kt # core/src/com/unciv/ui/screens/cityscreen/CityConstructionsTable.kt # core/src/com/unciv/ui/screens/cityscreen/CityStatsTable.kt
|
This improvement to the city building queue is really needed, I'm looking forward to it. The previous PR you mentioned hasn't been implemented yet, right? |
|
Thank you guys for your positive feedback! 🙂 Some of these changes are 2 months old, I'll double check those tomorrow 👍 |
core/src/com/unciv/ui/screens/cityscreen/CityConstructionsTable.kt
Outdated
Show resolved
Hide resolved
…es in the city screen. Minor fix for queue buttons.
|
I double-checked all changes and I think we now have a decent state. The only thing that bothers me a little is that hack with @NahuelGeno to answer your question, the previous PR wasn't merged because it "timed out". I was lacking time to finish it. @yairm210 I agree we should listen to the community for further improvements. By introducing the mini-queue, this PR focuses on cramped portrait and cramped landscape android screens. That is, the average android phone people likely have. I added some in-code reasoning as to how it manages vertical space better (Landscape). It also handles horizontal space better in cramped-portrait by moving the priority buttons. There's still room for improvement though since some entry descriptions tend to waste some horizontal space, but let's postpone that. From my perspective, (if we don't find a better way for that toggle-hack), the PR is ready to merge 😃 🎉 |
core/src/com/unciv/ui/screens/cityscreen/CityConstructionsTable.kt
Outdated
Show resolved
Hide resolved
See previous PR #12341.
Improved since then: