Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lock task to v3.39.2 to work around behaviour change in v3.40.0. #22

Merged
merged 1 commit into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ RUN ./tools/scripts/lib_install/linux/install-dev.sh
RUN ./tools/scripts/lib_install/linux/install-lib.sh

# NOTE:
# `task` doesn't have an apt/yum package so we use its install script.
RUN sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b /usr/local/bin
# - `task` doesn't have an apt/yum package so we use its install script.
# - We lock task's version since v3.40.0 and higher change the behaviour of how undefined variables
# are treated in `ref` statements, causing yscope-dev-utils' `validate-checksum` task to fail.
RUN sh -c "$(curl --location https://taskfile.dev/install.sh)" -- -d -b /usr/local/bin v3.39.2

# Remove cached files
RUN apt-get clean \
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/code-linting-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ jobs:
with:
python-version: "3.10"

# We lock task's version since v3.40.0 and higher change the behaviour of how undefined
# variables are treated in `ref` statements, causing yscope-dev-utils' `validate-checksum`
# task to fail.
- name: "Install task"
run: "npm install -g @go-task/cli"
run: "npm install -g @go-task/cli@3.39.2"

- if: "matrix.os == 'macos-latest'"
name: "Install coreutils (for md5sum)"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Follow the steps below to develop and contribute to the project.

## Requirements
* Python 3.10 or higher
* [Task] 3.38.0 or higher
* [Task] >= 3.38.0, < 3.40.0

## Set up
Initialize and update submodules:
Expand Down