refactor: Remove redundant this when referring to member variables.
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypedefs to the top of the file to fix compilation error.
…pp files; Also remove RegexDFA.tpp file.
…ector instead of set.
Co-authored-by: Lin Zhihao <[email protected]>
Co-authored-by: Lin Zhihao <[email protected]>
Co-authored-by: Lin Zhihao <[email protected]>
Co-authored-by: Lin Zhihao <[email protected]>
Co-authored-by: Lin Zhihao <[email protected]>
Co-authored-by: Lin Zhihao <[email protected]>
…fMohamed/log-surgeon into remove-redundant-typenames
LinZhihao-723
approved these changes
Jan 8, 2025
SharafMohamed
changed the title
this when referring to member variables.
This was referenced Jan 9, 2025
refactor: Move
epsilon_closure from Lexer to NfaState; Refactor nfa_to_dfa as Dfa's constructor.
#71
Merged
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this->varto refer to member variables in classes. We switched the standard to usem_var. This PR updates previous code to meet this standard.using Parser<TypedNfaState, TypedDfaState>::m_lexer;added to the top ofLalr1Parservariables in thePrivatesection. This allowsthis->m_lexerof theParserparent class to be used asm_lexerinLalr1Parser.Validation performed
Previously existing tests still succeed.