-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taskfile: Download and set up Meteor.js as part of building the package; Refactor tarball download and extraction into reusable task. #363
Merged
Merged
Changes from 6 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1a09b0c
Taskfile: Add Meteor setup task in Taskfile.yml.
junhaoliao 6dd6bd2
Remove Meteor setup steps from GitHub workflow.
junhaoliao 062fc5c
Revert task "webui-node-modules" back to internal in Taskfile.yml.
junhaoliao 531c5c7
Refactor Taskfile and lint-tasks.yml to extract common download and e…
junhaoliao 930ebbe
Merge branch 'refs/heads/main' into task-meteor-setup
junhaoliao d3fe1c5
Added webui-node-modules.md5 to sources of task `webui` in Taskfile.yml.
junhaoliao bc7e85f
Remove temp files resulted from `meteor build` before checksum.
junhaoliao 85409c9
Merge branch 'refs/heads/main' into task-meteor-setup
junhaoliao 60be034
Apply suggestions from code review
junhaoliao 1a13036
Mark task `webui-nodejs` as internal.
junhaoliao c13f267
Reduce sources array into one-line syntax for `download-tar-and-extra…
junhaoliao 5c62bd5
Add "meteor" to task `webui`'s deps.
junhaoliao 822250d
Rename `download-tar-and-extract` -> ``download-and-extract-tar`.
junhaoliao 705b74a
Rename `FILE_TAR_NAME` -> `TAR_NAME`.
junhaoliao 6242a8f
Refactor `FILE_BASE_DIR` -> `EXTRACTED_DIR` = `OUTPUT_DIR` + ``EXTRAC…
junhaoliao 023f7ad
Change mv command syntax from multiline to single-line string.
junhaoliao fa2c517
Move "meteor" above "validate-checksum" to stay alphabetical.
junhaoliao 6e0e263
Extract first temporary path then move to preseve hidden files.
junhaoliao ee73432
Added "run: once" attribute to the task `meteor` to prevent it for ru…
junhaoliao aedc2fe
Alphabetize vars{}.
junhaoliao c65e238
Apply suggestions from code review
junhaoliao f20b158
Added preconditions to task meteor to prevent running it on Linux ARM.
junhaoliao 52883fe
Apply suggestions from code review
junhaoliao dd2f5b9
Remove Node.js and Meteor.js from the building prerequisites in the d…
junhaoliao 8a4b223
Merge branch 'refs/heads/main' into task-meteor-setup
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haiqi96 I noticed we have this
platform
attribute for taskwebui
. Does it mean the task only runs on x86 platforms? Now that we also set up the arch-specific meteor and nodejs, do we still need the restriction here? (My insights are limited as I'm not too sure how the webui is built currently for your workflowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
meteor build --architecture
now support ARM platform IDs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the oversight. It doesn't seem to be the case.
The aarch64 related handling was added into the install script together with the 2.14 -> 2.15 upgrade so I mistakenly thought it was available for download. https://static.meteor.com/packages-bootstrap/2.15/meteor-bootstrap-os.linux.aarch64.tar.gz just doesn't open.
ARM support is expected to be available in meteor 3.0 though.