Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix isolation exit #834

Merged
merged 14 commits into from
Dec 12, 2024
Merged

Conversation

codingl2k1
Copy link
Contributor

Fix

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Dec 7, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.77%. Comparing base (ed16df7) to head (1e218d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   81.97%   82.77%   +0.79%     
==========================================
  Files        1071     1071              
  Lines       80168    80176       +8     
  Branches    12207    12209       +2     
==========================================
+ Hits        65719    66363     +644     
+ Misses      12910    12259     -651     
- Partials     1539     1554      +15     
Flag Coverage Δ
unittests 82.66% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 68a434a into xorbitsai:main Dec 12, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants