Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix config for xorbits and xorbits.pandas #818

Merged
merged 14 commits into from
Oct 6, 2024

Conversation

luweizheng
Copy link
Collaborator

  • add config options for xorbits
  • add set_option() and get_option() for xorbits
  • fix xorbits.pandas's bug when setting a non-existing option.
  • update docs on configuration and chunking.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Oct 5, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (92fdfc5) to head (864ffc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   82.97%   82.98%           
=======================================
  Files        1070     1071    +1     
  Lines       80039    80083   +44     
  Branches    16531    16545   +14     
=======================================
+ Hits        66411    66455   +44     
+ Misses      12033    12022   -11     
- Partials     1595     1606   +11     
Flag Coverage Δ
unittests 82.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hucorz hucorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 3304440 into xorbitsai:main Oct 6, 2024
31 of 32 checks passed
@luweizheng luweizheng deleted the config branch October 6, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants