Make Add/Remove member intents store wallet address #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhuaaa
approved these changes
Dec 11, 2023
proto/mls/database/intents.proto
Outdated
| } | ||
|
|
||
| // One of an EVM account address or Installation ID | ||
| message AddressOrInstallationId { |
There was a problem hiding this comment.
Should this be pluralized too?
insipx
merged commit 8d1c361
into
nmolnar/mls-verification-service
7 of 8 checks passed
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 XMTP Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
🎉 This PR is included in version 3.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into Nick's branch which the protos are generated from in
xmtp_mlscurrently.Companion to xmtp/libxmtp#363