Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: publish dart on release, fix semver for kt and dart #112

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

dmccartney
Copy link
Contributor

This fixes two issues:

  • publish-dart.yml wasn't being triggered because it was waiting for a new v#.#.# tag which was being pushed by the release.yml workflow. But GH actions generally can't trigger other GH actions (to avoid infinite robot dance loops)
  • the kotlin build was publishing artifacts with the prior version because it wasn't waiting for the JS build to first calculate the new v

This fixes both by moving dart publishing into the release.yml workflow and sequencing both the dart and kotlin jobs to run after the js job publishes the new v#.#.# tag.

@dmccartney dmccartney requested a review from a team as a code owner October 25, 2023 22:38
@dmccartney dmccartney requested a review from nplasterer October 25, 2023 22:38
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like I learn a new GitHub Actions power tool every day!

@dmccartney dmccartney merged commit de642c2 into main Oct 25, 2023
@dmccartney dmccartney deleted the daniel-dart-pub-release branch October 25, 2023 22:45
@dmccartney
Copy link
Contributor Author

dmccartney commented Oct 25, 2023

Blarg, this failed. pub.dev rejects GH actions that aren't directly triggered by a tag push -- so it can't come from this workflow. I'm going to manually publish for now and revisit this later.

@github-actions
Copy link

🎉 This PR is included in version 3.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants