Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Windows on ARM64 builds for CI #6056

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ifarbod
Copy link
Contributor

@ifarbod ifarbod commented Jan 11, 2025

The x64 version runs under emulation, but won't use HostARM64 tools, having a native arm version would make more sense.

xmake-winarm64.zip

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 11, 2025

I think LuaJIT doesn't support arm64, might have to take that off.

@SirLynix
Copy link
Member

LuaJIT does support arm64, see LuaJIT/LuaJIT#593

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 11, 2025

@SirLynix Well i just tried it on a Surface tablet and it won't run so I have to debug it :D

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 11, 2025

@waruqi It'd be nice to have the native ARM64 version working in the next release before v3.0.

@waruqi
Copy link
Member

waruqi commented Jan 11, 2025

we need to upload to artifacts/releases on ci, and fix all ci errors

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 11, 2025

Let me know if you need testing on windows arm64 hardware

@waruqi
Copy link
Member

waruqi commented Jan 11, 2025

I have no windows arm64 device.

@qudix
Copy link
Contributor

qudix commented Jan 11, 2025

I'm assuming xmake uses a version based on luajit-v2.1.0-beta3 which is 3 years before they added support for windows arm64

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 11, 2025

@waruqi If you have an Apple Silicone Mac, you can install Parallels or VirtualBox on it, they can run Windows 11 or Server 2025 ARM64

@waruqi
Copy link
Member

waruqi commented Jan 12, 2025

Upgrading Luajit requires a lot of changes and I don't have time to upgrade it for the moment.

@waruqi waruqi closed this Jan 13, 2025
@waruqi waruqi reopened this Jan 13, 2025
@waruqi
Copy link
Member

waruqi commented Jan 13, 2025

Program 'xmake.exe' failed to run: An error occurred trying to start process 'D:\a\xmake\xmake\xmake\xmake.exe'
| with working directory 'D:\a\xmake\xmake'. The specified executable is not a valid application for this OS

We cannot test it on ci.

@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 14, 2025

Windows x64 cannot emulate ARM64 .exe files (it's the other way around)

Free ARM64 CI images for Windows will be available very soon

https://github.com/orgs/github/projects/4247/views/1?pane=issue&itemId=65252539&issue=github%7Croadmap%7C970

@waruqi
Copy link
Member

waruqi commented Jan 14, 2025

we can skip luajit test for win/arm64 first. because I have no time to update and fix it.

or you can try to update luajit.

@waruqi waruqi added this to the v2.9.8 milestone Jan 16, 2025
@waruqi waruqi merged commit d621569 into xmake-io:dev Jan 16, 2025
21 checks passed
@ifarbod
Copy link
Contributor Author

ifarbod commented Jan 17, 2025

@waruqi Does the release version use luajit or regular lua?

@waruqi
Copy link
Member

waruqi commented Jan 17, 2025

@waruqi Does the release version use luajit or regular lua?

lua now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants