Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake tool generate smaller pdb on windows #5031

Closed
wants to merge 6 commits into from
Closed

Conversation

c8ef
Copy link
Member

@c8ef c8ef commented Apr 29, 2024

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

Based on grpc/grpc#36259, large project can benefit from these flags significantly.

On my windows machine, the default flag:

-- CMAKE_C_FLAGS is /DWIN32 /D_WINDOWS /W3
-- CMAKE_CXX_FLAGS is /DWIN32 /D_WINDOWS /W3 /GR /EHsc
-- CMAKE_EXE_LINKER_FLAGS is /machine:x64
-- CMAKE_SHARED_LINKER_FLAGS is /machine:x64
-- CMAKE_STATIC_LINKER_FLAGS is /machine:x64

@c8ef c8ef closed this Apr 29, 2024
@c8ef c8ef deleted the dev branch April 29, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants