Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
Signed-off-by: Tyler Gu <[email protected]>
  • Loading branch information
tylergu committed Nov 1, 2023
1 parent 4cbf7c0 commit 0708043
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions acto/kubernetes_engine/base.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
import subprocess
import time
from abc import ABC, abstractmethod
from typing import Callable, List, Tuple
from typing import Callable, Dict, List

import kubernetes

from acto.constant import CONST
from acto.utils import get_thread_logger

KubernetesEnginePostHookType = Callable[[kubernetes.client.ApiClient], None]
KeyValuePairType = Tuple[str, str]


class KubernetesEngine(ABC):

@abstractmethod
def __init__(self, acto_namespace: int,
posthooks: List[KubernetesEnginePostHookType] = None,
feature_gates: List[KeyValuePairType] = None) -> None: ...
feature_gates: Dict[str, str] = None) -> None: ...
'''Constructor for KubernetesEngine
Args:
Expand Down
4 changes: 2 additions & 2 deletions acto/kubernetes_engine/kind.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os
import subprocess
import time
from typing import List
from typing import Dict, List

import kubernetes
import yaml
Expand All @@ -17,7 +17,7 @@ class Kind(base.KubernetesEngine):

def __init__(
self, acto_namespace: int, posthooks: List[base.KubernetesEnginePostHookType] = None,
feature_gates: List[base.KeyValuePairType] = None):
feature_gates: Dict[str, str] = None):
self._config_path = os.path.join(CONST.CLUSTER_CONFIG_FOLDER, f'KIND-{acto_namespace}.yaml')
self._posthooks = posthooks
self._feature_gates = feature_gates
Expand Down

0 comments on commit 0708043

Please sign in to comment.