build: link tests and benches against shared library, not static library #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
meson-tests-shared
branch
5 times, most recently
from
72354da to
ef940c3
Compare
|
With some effort I got windows to work, unfortunately it required some additional commits. |
|
Nice work! Could you add a milestone to your PRs, if relevant? We are close to 1.8 release. Unfortunately, I also found myself keeping adding MRs after discovering bugs or limitations, but we ought to do the release soon, else we may miss some distro packages freeze that will not ship important bug fixes. |
|
Sure -- I added this and #614 to the 1.9.0 milestone. |
wismill
added
enhancement
bluetech
force-pushed
the
meson-tests-shared
branch
2 times, most recently
from
938f282 to
2c1dd81
Compare
|
Looks like |
Signed-off-by: Ran Benita <[email protected]>
bluetech
force-pushed
the
meson-tests-shared
branch
from
2c1dd81 to
073760e
Compare
Signed-off-by: Ran Benita <[email protected]>
The Windows dllexport annotation wants to be on the declarations, not the definitions. Signed-off-by: Ran Benita <[email protected]>
Without this, the test-internal libraries (which don't use the .def file because they contain additional private symbols) can't be made shared. But it also makes sense for consistency with GCC. Signed-off-by: Ran Benita <[email protected]>
This makes the tests, and especially benches, more realistic, since xkbcommon is almost always used as a shared library. Also significantly reduces the build time with LTO enabled (for me, from 90s to 30s). Signed-off-by: Ran Benita <[email protected]>
bluetech
force-pushed
the
meson-tests-shared
branch
from
073760e to
b9c6f59
Compare
|
Added a fix for the Windows error & warning, should be good now... |
wismill
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests, and especially benches, more realistic, since xkbcommon is almost always used as a shared library.
Also significantly reduces the build time with LTO enabled (for me, from 90s to 30s).