updated bunny to the latest version #56
Merged
+145
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using heartbeats should be fine for us. We just turned it off by default, but some clients are already using the feature. |
skaes
force-pushed
the
bunny-update
branch
4 times, most recently
from
b0911ca to
3dea802
Compare
The tests are green, but we need to study the interplay between the various new timeout options in the multi threaded bunny implementation. This is still WIP!!!
This reverts commit c7b4b0e.
|
Let's resurrect and bring this to completion. @skaes has done all the groundwork already. Thank you :) |
|
Ok we're taking over from here and since the last changes made here a couple of things have happened on our end that force us to speed up and also take some risks. We need heartbeats to work with publishers, as we're switching to new rabbit servers which run behind a NLB. Additionally we have to enable strict publishing timeouts to fail faster if a server isn't reachable. We will not merge this change into master but keep the 4.1 branch for that and potentially create a diverging long lived branch for follow-up changes. |
This brings updates to the heartbeat implementation which we should get in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are green, but we need to study the interplay between the
various new timeout options in the multi threaded bunny implementation.
In addition, the new bunny insists on having heartbeats enabled, which
we have turned off on our brokers.