fix: do not copy .gitignore into container

Co-authored-by: Markus Wolf <[email protected]>

pkg/container/docker_run.go

@@ -512,6 +512,11 @@ func (cr *containerReference) copyDir(dstPath string, srcPath string, useGitIgno
 				return err
 			}
 
+			if fi.Name() == ".gitignore" {
+				log.Debug("Ignoring .gitignore file")
+				return nil
+			}
+
 			sansPrefix := strings.TrimPrefix(file, srcPrefix)
 			split := strings.Split(sansPrefix, string(filepath.Separator))
 			if ignorer != nil && ignorer.Match(split, fi.IsDir()) {

pkg/runner/step_context.go

@@ -428,10 +428,10 @@ func (sc *StepContext) runAction(actionDir string, actionPath string) common.Exe
 					return nil
 				}
 			}
-			err := removeGitIgnore(actionDir)
-			if err != nil {
-				return err
-			}
+			// err := removeGitIgnore(actionDir)
+			// if err != nil {
+			// 	return err
+			// }
 			return rc.JobContainer.CopyDir(containerActionDir+"/", actionLocation+"/", rc.Config.UseGitIgnore)(ctx)
 		}
 
@@ -654,12 +654,9 @@ func removeGitIgnore(directory string) error {
 	if _, err := os.Stat(gitIgnorePath); err == nil {
 		// .gitignore exists
 		log.Debugf("Removing %s before docker cp", gitIgnorePath)
-		// ignore errors which might happen if multiple jobs try to delete the
-		// .gitignore file in parallel
 		err := os.Remove(gitIgnorePath)
 		if err != nil {
-			log.Warn("Error while removing .gitignore")
-			return nil
+			return err
 		}
 	}
 	return nil