Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetNameFromTypeCode from web-ifc #1352

Closed

Conversation

cvillagrasa
Copy link
Contributor

This little PR updates IFC Loader to correctly retrieve IFC classes (follow up to #1185).

It uses web-ifc's updated GetNameFromTypeCode, thanks to @beachtom recent fix.

DO NOT MERGE YET: web-ifc 0.0.51 is not released yet

@ghost
Copy link

ghost commented Jan 26, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cvillagrasa
Copy link
Contributor Author

So now, web-ifc 0.0.51 is already out. I tried to test this PR but could only do so for the non-minified build. It works well and the casing for metaObject.type is PascalCase, as expected.

I couldn't test it on the minified build, though. On my setup, Rollup seems to complain with a bunch of errors when doing npm run build. Anyways, this little PR should be ready to merge.

Let me know if otherwise it's better that I correcly setup Rollup to fully test the minified build as well.

@xeolabs
Copy link
Member

xeolabs commented Mar 4, 2024

Cool, I just merged web-ifc 0.0.51 into @xeokit/xeokit-sdk 2.5.2-beta-30 - see #1396

@xeolabs xeolabs closed this Mar 4, 2024
@cvillagrasa
Copy link
Contributor Author

Thanks! Although I see the web-ifc bump, but I think 9dcb320 is still needed.

@xeolabs
Copy link
Member

xeolabs commented Mar 5, 2024

Got it, fixed in https://github.com/xeokit/xeokit-sdk/releases/tag/v2.5.2-beta-32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants