-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows PV tools installer tests #262
Conversation
3ec9fab
to
14f4a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a nice addition to the tests. Here are my review comments.
23f3981
to
c71c263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
I'm doing some refactoring to make testing multiple guest tools/other tools versions a bit easier. Currently running final tests. |
83d7e20
to
50e8dd4
Compare
I've refactored the tests as following:
|
50e8dd4
to
55668e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few minor comments.
I will delay my approval until we have setup the tests in our CI so that they run once merged on master.
dbb6877
to
f7f0d97
Compare
f7f0d97
to
1004baf
Compare
1004baf
to
c225bb8
Compare
I've added some tools and scripts useful for reducing Windows image sizes. |
c225bb8
to
1bc1aab
Compare
I've switched the ISO download code to use the existing NFS ISO SR config. |
1bc1aab
to
63bf767
Compare
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
16a43a3
to
c5d8821
Compare
502beda
to
e904ca2
Compare
Signed-off-by: Tu Dinh <[email protected]>
e904ca2
to
caa0171
Compare
Signed-off-by: Tu Dinh <[email protected]>
caa0171
to
864b172
Compare
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
864b172
to
f82af42
Compare
Changes since last time:
Upgrades are marked as xfail since they require multiple reboots, which I haven't yet taken into account. |
Signed-off-by: Tu Dinh <[email protected]>
a5e870e
to
362534d
Compare
The vendor device being present will cause Windows to reinstall XenServer drivers automatically, so skip XenClean tests in these situations. Signed-off-by: Tu Dinh <[email protected]>
CI:
|
Thanks for a good PR! |
This PR adds tests for the new XCP-ng 9.x Windows PV Tools installer.
It tests various actions of the installer (install, uninstall, upgrade) under various conditions (with XCP-ng v8 tools, with Citrix tools, with Windows Update drivers, etc.)
It adds a dependency on 2 new ISO images, the structures of which are documented below:
I have run these tests on Windows Server 2016, 2019, 2022 and 2025. I used customized images with testsigning enabled.