Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/xen: add test-pv64-xsa-444 to list of common skips for XTF #185

Merged
merged 3 commits into from
Jan 9, 2024
Merged

tests/xen: add test-pv64-xsa-444 to list of common skips for XTF #185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9bc278
tests/xen: document the expected skip reasons for XTF tests
stormi Jan 8, 2024
91a52b6
tests/xen: make logs clearer when an unexpected XTF test is skipped
stormi Jan 8, 2024
27e63c4
tests/xen: add test-pv64-xsa-444 to list of common skips for XTF
stormi Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/xen/test_xtf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,16 @@
@pytest.mark.usefixtures("host_with_hvm_fep", "host_with_dynamically_disabled_ept_sp")
class TestXtf:
_common_skips = [
# UMIP requires hardware support, that is a recent enough CPU
'test-hvm32-umip',
'test-hvm64-umip',
# PV Superpages, a thing which was removed long ago from the hypervisor. Always skips
'test-pv64-xsa-167',
'test-pv64-xsa-182'
# Depends on pv linear pagetables, which is disabled by default but can be activated on Xen's cmdline.
# Is not needed for Linux. It is for a NetBSD PV guest.
'test-pv64-xsa-182',
# Will skip if DBEXT support is not present
'test-pv64-xsa-444',
]

def _extract_skipped_tests(self, output):
Expand Down Expand Up @@ -42,6 +48,7 @@ def test_all(self, host, xtf_runner):
"Checking whether they belong to the allowed list...")
for skipped_test in skipped_tests:
if skipped_test not in self._common_skips:
logging.error(f"... At least one doesn't")
raise
logging.info("... They do")
else:
Expand Down
Loading