Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/xcpng fs diff.py #184

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Fix/xcpng fs diff.py #184

merged 4 commits into from
Dec 22, 2023

Conversation

tescande
Copy link
Contributor

Cosmetic changes and support for filenames containing special characters.

@tescande tescande self-assigned this Dec 22, 2023
@stormi
Copy link
Member

stormi commented Dec 22, 2023

pycodestyle complains

@tescande
Copy link
Contributor Author

pycodestyle complains

Yep, saw that and I don't get it... All errors are xcpng-fs-diff.py:1:XX: like the file is only 1 line !

Copy link
Contributor

@ydirson ydirson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stormi
Copy link
Member

stormi commented Dec 22, 2023

Naming your branch with a name ending with .py confused pycodestyle, who thinks the related ref in .git is a python file.

Don't exit displaying an error message if the script is executed with
the option -r and -s to only get and save the reference files.

Signed-off-by: Thierry Escande <[email protected]>
This fixes the script for filenames with special characters like spaces
and quotes.

Signed-off-by: Thierry Escande <[email protected]>
@tescande tescande force-pushed the fix/xcpng-fs-diff.py branch from 9e1d48a to 4a45b24 Compare December 22, 2023 14:25
@tescande tescande merged commit e313ff2 into master Dec 22, 2023
4 checks passed
@tescande tescande deleted the fix/xcpng-fs-diff.py branch December 22, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants