FIXMEs

lib/vm.py

@@ -449,6 +449,7 @@ def install_uefi_certs(self, auths):
             dest = self.host.ssh(['mktemp'])
             self.host.scp(auth.auth, dest)
             self.host.ssh([
+                # FIXME: didn't auth format evolve in 8.3? But maybe varstore-set's API itself didn't change.
                 'varstore-set', self.uuid, auth.guid.as_str(), auth.name,
                 str(efi.EFI_AT_ATTRS), dest
             ])

tests/uefi_sb/conftest.py

@@ -3,7 +3,7 @@
 
 from packaging import version
 
-@pytest.fixture(scope='module')
+@pytest.fixture(scope='module') # FIXME: why not package scope?
 def pool_without_uefi_certs(host):
     assert host.xcp_version < version.parse("8.3"), "fixture only relevant on XCP-ng 8.2"
     pool = host.pool

tests/uefi_sb/test_varstored_cert_flow.py

@@ -168,6 +168,7 @@ def test_switching_to_user_mode(self, uefi_vm):
 class TestPoolToDiskCertInheritanceOnPoolJoin:
     @pytest.fixture(scope='function')
     def keys_auths_for_joined_host(self, host, hostB1):
+        # FIXME: fixture vulnerable to setup or teardown errors?
         from packaging import version
         version_str = "8.3"
         if not hostB1.xcp_version >= version.parse(version_str):