Revert "CA-379329: check for missing iSCSI sessions and reconnect" (#65) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d28dcc1. Prevent bad disconnection of ISCSi targets In practice the commit that we revert is useful in the case where ISCSI connections are no longer valid, but sometimes even without any config change or bad connections, a disconnect/connect is launched preventing the correct use of the SR. This change is a workaround, we don't have a better solution at this time. Signed-off-by: Benjamin Reis <[email protected]>
Wescoeur
approved these changes
Aug 1, 2024
Nambrok
approved these changes
Aug 1, 2024
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Aug 1, 2024
See: xcp-ng/sm#66 Signed-off-by: Benjamin Reis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d28dcc1.
Prevent bad disconnection of ISCSi targets
In practice the commit that we revert is useful in the case where ISCSI connections are no longer valid, but sometimes even without any config change or bad connections, a disconnect/connect is launched preventing the correct use of the SR.
This change is a workaround, we don't have a better solution at this time.