Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ISPYB credentials has caused problems. #332

Open
tdudgeon opened this issue Aug 3, 2022 · 0 comments
Open

Removing ISPYB credentials has caused problems. #332

tdudgeon opened this issue Aug 3, 2022 · 0 comments
Assignees

Comments

@tdudgeon
Copy link
Contributor

tdudgeon commented Aug 3, 2022

We've recently provided the ability to skip adding ISPYB credentials to the environment of the stack to prevent having to add sensitive credentials to every developer stack, or have the logs polluted with lots or errors from ISPYB.

But this has caused downstream problems. See https://github.com/xchem/fragalysis-backend/blob/master/api/security.py#L35-L38 and https://github.com/xchem/fragalysis-backend/blob/master/api/security.py#L58-L61 where you encounter "no such key" errors.

There may also be other areas to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants