Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of ISpyB authentication (for dev stacks) #936

Open
phraenquex opened this issue Jul 26, 2022 · 4 comments
Open

Allow disabling of ISpyB authentication (for dev stacks) #936

phraenquex opened this issue Jul 26, 2022 · 4 comments

Comments

@phraenquex
Copy link
Collaborator

To fix the problem of the dev stgacks needing Frank's credentials, which is unnecessary security risk

@alanbchristie
Copy link
Collaborator

The existing code 'expects' ISPyB credentials (set via stack/Pod environment variables) and can't tolerate them not being set.

To avoid the error: -

  1. A user can set appropriate ISPyB credentials in their stack, or...
  2. We need to introduce new backend behaviour to tolerate (and possibly issue a log warning) if ISPyB credentials are not set.

@phraenquex
Copy link
Collaborator Author

@tdudgeon says there remains a bug (from few weeks ago) - @alanbchristie to review

@alanbchristie
Copy link
Collaborator

See also xchem/fragalysis-backend#332

@phraenquex
Copy link
Collaborator Author

@boriskovar-m2ms you need to test this - by doing something in a dev stack that an ISpyB-logged-in user is able to do. I.e. Boris should see no errors.

@mwinokan mwinokan moved this to In production (Done) in Fragalysis May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants