Apply suggestions from code review

Co-authored-by: Pascal Bourgault <[email protected]>
xarray-contrib · Jan 19, 2024 · f96948a · f96948a
1 parent 37c8f19
commit f96948a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cf_xarray/geometry.py b/cf_xarray/geometry.py
@@ -499,12 +499,12 @@ def polygons_to_cf(polygons: xr.DataArray | Sequence):
     if coord is not None:
         ds = ds.assign_coords({dim: coord})
 
-    # Special case when we have no MultiPolygons
+    # Special case when we have no MultiPolygons and no holes
     if len(ds.part_node_count) == len(ds.node_count):
         ds = ds.drop_vars("part_node_count")
         del ds.geometry_container.attrs["part_node_count"]
 
-    # Special case when we have not holes
+    # Special case when we have no holes
     if (ds.interior_ring == 0).all():
         ds = ds.drop_vars("interior_ring")
         del ds.geometry_container.attrs["interior_ring"]

diff --git a/cf_xarray/tests/test_geometry.py b/cf_xarray/tests/test_geometry.py
@@ -176,7 +176,7 @@ def geometry_polygon_without_multipolygons_ds():
         Polygon(
             ([70, 50], [60, 65], [50, 50]),
             [
-                ([55, 55], [60, 60], [75, 55]),
+                ([55, 55], [60, 60], [65, 55]),
             ],
         ),
     ]