Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rubocop-govuk 4.13.0 #493

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Upgrade to rubocop-govuk 4.13.0 #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ AllCops:
Exclude:
- govuk_design_system_formbuilder.gemspec
- spec/dummy/**/*
- guide/node_modules/**/*
Security/Eval:
Exclude:
- guide/lib/helpers/formatters.rb
Expand Down
2 changes: 1 addition & 1 deletion app/components/govuk_component/accordion_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class GovukComponent::AccordionComponent < GovukComponent::Base
GovukComponent::AccordionComponent::SectionComponent.new(
classes: classes,
expanded: expanded,
heading_level: heading_level, # set once at parent level, passed to all children
heading_level: heading_level, # set once at parent level, passed to all children
html_attributes: html_attributes,
summary_text: summary_text,
heading_text: heading_text,
Expand Down
2 changes: 1 addition & 1 deletion govuk-components.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "pry-byebug"
spec.add_development_dependency "rspec-html-matchers", "~> 0.9"
spec.add_development_dependency "rspec-rails"
spec.add_development_dependency "rubocop-govuk", "= 4.12.0"
spec.add_development_dependency "rubocop-govuk", "= 4.13.0"
spec.add_development_dependency "sassc-rails"
spec.add_development_dependency("simplecov", "~> 0.20")
spec.add_development_dependency "sqlite3"
Expand Down