Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cannot_start_yet argument to the task list status component #488

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

peteryates
Copy link
Member

It provides a nicer way to add the class govuk-task-list__status--cannot-start-yet than manually providing it.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit 5fa1e33
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/659466ff766a6700086574d0
😎 Deploy Preview https://deploy-preview-488--govuk-components.netlify.app/components/task-list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Wonder if we should throw an error if this is set to true and an href is present?

@peteryates
Copy link
Member Author

That sounds sensible to me. I don't think there's ever a reason for a row to be 'cannot start' and have a href 🤔

I guess a warning message in the log could work too if we want to give some degree of flexibility.

@frankieroberto
Copy link
Collaborator

I think I would go with raising an error as warnings in the logs can be missed or ignored - the error could also suggest that if you really wanted to do it, you could add the class manually?

(We could also drop the error in future if someone explains a good reason to have a link for something that can’t be started yet?)

@peteryates peteryates force-pushed the add-arg-for-setting-cannot-start-status branch from 408bd3b to 5fa1e33 Compare January 2, 2024 19:41
@peteryates peteryates added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit a9e260d Jan 2, 2024
12 checks passed
@peteryates peteryates deleted the add-arg-for-setting-cannot-start-status branch January 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants