Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the breadcrumb helper and add extra tests #484

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix the breadcrumb helper and add extra tests #484

merged 1 commit into from
Dec 18, 2023

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Dec 18, 2023 •
edited
Loading

This bug was kindly reported by @paulrobertlloyd.

Before After
Screenshot from 2023-12-18 16-01-56 Screenshot from 2023-12-18 16-02-15

@peteryates peteryates added the bug Something isn't working label Dec 18, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2023 •
edited
Loading

✅ Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit fd26f5b
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/65806cc40cad0e0008773f5f
😎 Deploy Preview https://deploy-preview-484--govuk-components.netlify.app/components/breadcrumbs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

frankieroberto
frankieroberto approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot!

@peteryates peteryates added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 10a240d Dec 18, 2023
12 checks passed
@peteryates peteryates deleted the fix-govuk-breadcrumb-link-classes branch December 18, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankieroberto frankieroberto frankieroberto approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peteryates @frankieroberto