Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust the location property #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adjust the location property #34

wants to merge 1 commit into from
+2 −2

Conversation

minikey
Copy link

@minikey minikey commented Oct 9, 2022

adjust the location so that eslint's SourceCode instance can work properly

@minikey minikey requested a review from dhlolo as a code owner October 9, 2022 08:39
@iChenLei iChenLei changed the title feat:adjust the location property feix: adjust the location property Oct 9, 2022
@iChenLei iChenLei changed the title feix: adjust the location property fix: adjust the location property Oct 9, 2022
dhlolo
dhlolo approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@dhlolo dhlolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice, @iChenLei, what do u think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhlolo dhlolo dhlolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minikey @dhlolo @fumin-inagora