Refactor Notification Handling and Rename Firebase Service Worker Scope #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements and refactors to streamline notification handling and improve code clarity. The changes are as follows:
Renaming for Clarity
HandlerNotification
toNewCredentialNotification
for better alignment with its purpose.Enhanced Notification Listening
listenForNotifications
logic into a higher-order hook for improved reusability and modularity, and rename it touseNewCredentialListener
.useNewCredentialListener
to use aref
for thegetData
function, preventing unnecessary re-renders and ensuring consistent behavior.Improved Service Worker Scope (Related with: #77)
Persistent Notification Handling
sessionStorage
to temporarily store notifications, ensuring they are displayed even after a page reload or redirection.Fixes and Refinements
Benefits