pull from devel to master to create release 68.2.0 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were testing the ability to infer different paths, which is already tested in npg_tracking GitHub repo. The deleted tests were for some unlikely or old scenarios. Some of the deleted tests started to fail following the reorganisation and simplification of the npg_tracking::illumina::runfolder class and its dependencies in wtsi-npg/npg_tracking#812
Removed unnecessary unit tests.
Wrapped around the inherited method in npg_pipeline::product so that it works for partial merges. Removed a flag that previously has to be passed to this method. This fixes a bug in npg_pipeline::validation::entity - incorrect prediction of paths for partial merges.
This reverts commit 5a8873f.
Revert "Runs with data analysed on-board are not deletable."
Extended the dir_path method of the product.
Added an option to exclude lanes from a merge.
Updated Changes file for release 68.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.