Fix baton-list and baton-do list operation not printing null checksums #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an incorrect check for JSON null, the checkum attribute was omitted from output JSON, even when specifically requested. This change fixes that behaviour and also rationalises the naming of the checksum flags for the print, calculate and verify operations so that they are more explicit.
marcomoscasgr
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks good to me.
Probably for another PR: while searching for json_array_get I found there is another nested call with json_incref(json_array_get(...)) in list.c line 69. I am not sure if that would affect the outcome in data_object variable (json_incref may be called on NULL), but probably it is worth to check it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an incorrect check for JSON null, the checkum attribute was omitted from output JSON, even when specifically requested. This change fixes that behaviour and also rationalises the naming of the checksum flags for the print, calculate and verify operations so that they are more explicit.