Fix CPU spinning issue #2191
Merged
Fix CPU spinning issue #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When back-end connection is closed (RST sent) while handling the response if the protocol state is already marked as RESPONSE_DONE in the TargetHandler exception patch we have omitted to close the connection so the connection remain intact and it will continue to hit the inputReady method and when trying to read from the SSLIOSession it will throws a I/O Exception but since in the exception patch we are omitting the error this will loop. Fixed this issue by moving the connection close logic to finally block. Fixes: wso2/product-micro-integrator#3363
SanojPunchihewa
approved these changes
Jun 17, 2024
shilmyhasan
pushed a commit
to shilmyhasan/wso2-synapse-1
that referenced
this pull request
Aug 28, 2024
…v183.x-full Fixing issue in update Synapse Artifact flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When back-end connection is closed (RST sent) while handling the response if the protocol state is already marked as RESPONSE_DONE in the TargetHandler exception patch we have omitted to close the connection so the connection remain intact and it will continue to hit the inputReady method and when trying to read from the SSLIOSession it will throws a I/O Exception but since in the exception patch we are omitting the error this will loop.
Fixed this issue by moving the connection close logic to finally block.
Fixes: wso2/product-micro-integrator#3363