Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PAR request scenarios #21336

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Improve PAR request scenarios #21336

merged 2 commits into from
Oct 21, 2024

Conversation

Thumimku
Copy link
Contributor

Public Issue : #21313

Current PAR integration suite doesn't test negative cases hence with this PR validates cases such as,

  • Send authorize user request with invalid client id
  • Send authorize user request with invalid request uri
  • Send authorize user request with expired request uri
  • Send PAR with repeated param
  • Send PAR with invalid client id
  • Send PAR without client id
  • Send PAR with invalid response type
  • Send PAR with invalid redirect uri
  • Send PAR with request uri

Note:The testSendAuthorizeWithExpiredRequestURI method will pause execution for one minute to allow the request URI to expire.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11321152665

@Thumimku Thumimku mentioned this pull request Oct 14, 2024
Open
10 tasks
@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11321152665
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11321152665

@Thumimku Thumimku requested a review from Yoshani October 16, 2024 05:53
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11399808872

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11399808872
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11399808872

@Thumimku Thumimku merged commit 1339498 into wso2:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoshani Yoshani Yoshani approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thumimku @jenkins-is-staging @Yoshani