Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method to get federated authenticator by name. #6363

Merged

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

Create new method to get the FederatedAuthenticatorByName for both SYSTEM and USER defined users.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.41%. Comparing base (f4edfa8) to head (f9d5db7).
Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
...cation/common/ApplicationAuthenticatorService.java 0.00% 5 Missing ⚠️
...g/wso2/carbon/idp/mgt/IdentityProviderManager.java 77.77% 2 Missing ⚠️
.../framework/internal/FrameworkServiceComponent.java 0.00% 1 Missing ⚠️
.../main/java/org/wso2/carbon/idp/mgt/IdpManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6363      +/-   ##
============================================
+ Coverage     46.33%   46.41%   +0.07%     
- Complexity    14681    14737      +56     
============================================
  Files          1707     1713       +6     
  Lines        103362   103607     +245     
  Branches      18508    18532      +24     
============================================
+ Hits          47895    48085     +190     
- Misses        48627    48672      +45     
- Partials       6840     6850      +10     
Flag Coverage Δ
unit 30.02% <43.75%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12966606668

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12966606668
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12966606668

@Thisara-Welmilla Thisara-Welmilla merged commit 4796514 into wso2:master Jan 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants