Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server startup created time null issue #6340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sachin-Mamoru
Copy link
Contributor

Purpose

In server startup, through the X509 we are persisting few resources to the configuration manager. But after activating only the created time is set.
This PR fixes that.

This pull request includes a minor but important change to the ConfigurationManagerComponent class. The change involves moving the registration of the ConfigurationManager service to ensure it occurs after setting the useCreatedTime flag.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12926557686

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.32%. Comparing base (da7ffe7) to head (59bca9c).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...t/core/internal/ConfigurationManagerComponent.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6340      +/-   ##
============================================
- Coverage     46.32%   46.32%   -0.01%     
  Complexity    14694    14694              
============================================
  Files          1695     1695              
  Lines        104024   104024              
  Branches      18580    18580              
============================================
- Hits          48190    48189       -1     
- Misses        48988    48989       +1     
  Partials       6846     6846              
Flag Coverage Δ
unit 29.83% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12926557686
Status: cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants