-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve framework to skip retry from authenticator #6334
Improve framework to skip retry from authenticator #6334
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6334 +/- ##
============================================
+ Coverage 45.31% 45.48% +0.17%
- Complexity 14544 15266 +722
============================================
Files 1656 1697 +41
Lines 104431 110450 +6019
Branches 18372 19669 +1297
============================================
+ Hits 47324 50240 +2916
- Misses 50288 53082 +2794
- Partials 6819 7128 +309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
To cover the newly added lines, AbstractAppAuthSkipRetryTest.java was introduced. Even though the tests covers the new lines, Codecov is not detecting it. I have locally checked that the test are covering the new lines added. |
PR builder started |
PR builder completed |
Quality Gate passedIssues Measures |
Currently, if an authenticator fails, the reason for the failure will be shown when the authenticator is re-executed. For this, the authenticator depends on the retryAuthenticationEnabled function. The resend mechanism also depends on the same method. For scenarios where the user denies the authentication flow from the authenticator, the user has to be redirected to the application with an error message without retrying the authenticator.
This improvement addresses the above mentioned concern.