Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuthenticatorAdapterService to get authentiactor instance for user defined authenticators. #6319

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

With the custom authentocation extenstion support, there will be user defined authenticators engaging in the authentication flow. We need to introduce new service to get the authenticator instance for user defined authenticator.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-adapter-service branch 6 times, most recently from 0e73bf1 to 2c95772 Compare January 21, 2025 16:18
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12891326226

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12891326226
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-adapter-service branch 2 times, most recently from fc029ea to 7f19270 Compare January 22, 2025 01:38
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-adapter-service branch 7 times, most recently from e629bb5 to 8086955 Compare January 24, 2025 12:26
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12961849190

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12961849190
Status: failure

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12961962993

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12961962993
Status: failure

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 29.75207% with 85 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (ca50524) to head (5f1d660).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...internal/core/ApplicationAuthenticatorManager.java 50.00% 16 Missing and 1 partial ⚠️
.../authentication/framework/util/FrameworkUtils.java 12.50% 14 Missing ⚠️
...on/framework/ApplicationAuthenticationService.java 31.25% 11 Missing ⚠️
...ework/config/model/OptimizedApplicationConfig.java 0.00% 9 Missing ⚠️
.../framework/internal/FrameworkServiceComponent.java 0.00% 8 Missing ⚠️
...uthentication/framework/AuthenticationService.java 30.00% 7 Missing ⚠️
...n/framework/cache/AuthenticationContextLoader.java 0.00% 5 Missing ⚠️
...ramework/handler/step/impl/DefaultStepHandler.java 42.85% 3 Missing and 1 partial ⚠️
...work/config/loader/UIBasedConfigurationLoader.java 66.66% 2 Missing and 1 partial ⚠️
...framework/internal/FrameworkServiceDataHolder.java 0.00% 3 Missing ⚠️
... and 2 more

❌ Your patch check has failed because the patch coverage (29.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6319      +/-   ##
============================================
- Coverage     46.27%   46.20%   -0.07%     
- Complexity    14712    14765      +53     
============================================
  Files          1701     1709       +8     
  Lines        104292   104789     +497     
  Branches      18342    18567     +225     
============================================
+ Hits          48259    48417     +158     
- Misses        49180    49480     +300     
- Partials       6853     6892      +39     
Flag Coverage Δ
unit 29.87% <29.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants