-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuthenticatorAdapterService to get authentiactor instance for user defined authenticators. #6319
base: master
Are you sure you want to change the base?
Add AuthenticatorAdapterService to get authentiactor instance for user defined authenticators. #6319
Conversation
0e73bf1
to
2c95772
Compare
PR builder started |
PR builder completed |
fc029ea
to
7f19270
Compare
7f19270
to
17db819
Compare
e629bb5
to
8086955
Compare
8086955
to
5cb8b31
Compare
PR builder started |
PR builder completed |
Quality Gate failedFailed conditions |
PR builder started |
PR builder completed |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (29.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6319 +/- ##
============================================
- Coverage 46.27% 46.20% -0.07%
- Complexity 14712 14765 +53
============================================
Files 1701 1709 +8
Lines 104292 104789 +497
Branches 18342 18567 +225
============================================
+ Hits 48259 48417 +158
- Misses 49180 49480 +300
- Partials 6853 6892 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue:
With the custom authentocation extenstion support, there will be user defined authenticators engaging in the authentication flow. We need to introduce new service to get the authenticator instance for user defined authenticator.