Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logging and throwing error as it is an anti pattern #6272

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix error logging and throwing error as it is an anti pattern #6272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ....provisioning/src/main/java/org/wso2/carbon/identity/provisioning/ProvisioningThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/*
* Copyright (c) 2014, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
* Copyright (c) 2014-2025, WSO2 LLC. (http://www.wso2.com).
*
* WSO2 Inc. licenses this file to you under the Apache License,
* WSO2 LLC. licenses this file to you under the Apache License,
* Version 2.0 (the "License"); you may not use this file except
* in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
Expand Down Expand Up @@ -118,9 +118,9 @@ public Boolean call() throws IdentityProvisioningException {
}
success = true;
} catch (Exception e) {
String errMsg = " Provisioning for Entity " + provisioningEntity.getEntityName() +
String errMsg = "Fail the Provisioning for Entity " + provisioningEntity.getEntityName() +
" For operation = " + provisioningEntity.getOperation();
log.error(errMsg, e);
log.warn(errMsg);
throw new IdentityProvisioningException(errMsg, e);
} finally {
PrivilegedCarbonContext.endTenantFlow();
Expand Down
Loading