-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle and refactor rule management service #6265
Conversation
These issues are not quite valid. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6265 +/- ##
============================================
+ Coverage 45.46% 45.64% +0.17%
- Complexity 14157 14304 +147
============================================
Files 1633 1653 +20
Lines 102871 103343 +472
Branches 18128 18152 +24
============================================
+ Hits 46772 47171 +399
- Misses 49277 49339 +62
- Partials 6822 6833 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
...ule.management/src/main/java/org/wso2/carbon/identity/rule/management/dao/impl/RuleData.java
Outdated
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Show resolved
Hide resolved
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12644699602
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Outdated
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Outdated
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Outdated
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Show resolved
Hide resolved
...rule.management/src/main/java/org/wso2/carbon/identity/rule/management/util/RuleBuilder.java
Show resolved
Hide resolved
d1bbcdf
to
3d7d90d
Compare
Quality Gate passedIssues Measures |
Proposed changes in this pull request
Resolves wso2/product-is#22172
With respect to utilizing this service at the API layer, this PR applies following refactoring.
Along with above improvements the rule management service is bundled with the rule management server feature to package in the product.