Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle and refactor rule management service #6265

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

malithie
Copy link
Member

@malithie malithie commented Jan 7, 2025

Proposed changes in this pull request

Resolves wso2/product-is#22172

With respect to utilizing this service at the API layer, this PR applies following refactoring.

  • further validations are added to validate the rule
  • internal rule structure is exposed to compose the rule response

Along with above improvements the rule management service is bundled with the rule management server feature to package in the product.

@malithie
Copy link
Member Author

malithie commented Jan 7, 2025

3 New issues

These issues are not quite valid.
Suggestion on the test improvement is valid. Will refactor in a different iteration.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 83.54430% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.64%. Comparing base (f958875) to head (3d7d90d).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...bon/identity/rule/management/util/RuleBuilder.java 85.93% 7 Missing and 2 partials ⚠️
...bon/identity/rule/management/model/Expression.java 83.33% 0 Missing and 2 partials ⚠️
...o2/carbon/identity/rule/management/model/Rule.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6265      +/-   ##
============================================
+ Coverage     45.46%   45.64%   +0.17%     
- Complexity    14157    14304     +147     
============================================
  Files          1633     1653      +20     
  Lines        102871   103343     +472     
  Branches      18128    18152      +24     
============================================
+ Hits          46772    47171     +399     
- Misses        49277    49339      +62     
- Partials       6822     6833      +11     
Flag Coverage Δ
unit 28.91% <83.54%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12644699602

pom.xml Outdated Show resolved Hide resolved
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12644699602
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12644699602

Copy link

sonarqubecloud bot commented Jan 7, 2025

@malithie malithie merged commit 5be3bef into wso2:master Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle and refactor rule management service
5 participants