Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict inbound protocols for the sub organization applications #6217

Merged

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Dec 17, 2024

Proposed changes in this pull request

@ShanChathusanda93 ShanChathusanda93 marked this pull request as ready for review December 18, 2024 03:36
AnuradhaSK
AnuradhaSK previously approved these changes Dec 23, 2024
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (8960263) to head (932958b).
Report is 250 commits behind head on master.

Files with missing lines Patch % Lines
...lication/mgt/ApplicationManagementServiceImpl.java 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6217      +/-   ##
============================================
+ Coverage     45.62%   45.75%   +0.13%     
- Complexity    14039    14615     +576     
============================================
  Files          1632     1655      +23     
  Lines        100525   105078    +4553     
  Branches      17538    18601    +1063     
============================================
+ Hits          45861    48076    +2215     
- Misses        47977    50042    +2065     
- Partials       6687     6960     +273     
Flag Coverage Δ
unit 28.92% <50.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnuradhaSK
AnuradhaSK previously approved these changes Jan 7, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12651061803

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12651061803
Status: cancelled

@ShanChathusanda93 ShanChathusanda93 force-pushed the inbound-auth-restict-branch branch from f52ab4f to 932958b Compare January 9, 2025 05:57
Copy link

sonarqubecloud bot commented Jan 9, 2025

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12690197495

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12690197495
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12690197495

@ShanChathusanda93 ShanChathusanda93 merged commit a39480c into wso2:master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants