Handle portal app callback URLs #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashimalcse
previously approved these changes
Apr 26, 2024
ThaminduDilshan
previously approved these changes
Apr 26, 2024
|
PR builder started |
AnuradhaSK
reviewed
Apr 26, 2024
...plication.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ApplicationMgtUtil.java
Outdated
Show resolved
Hide resolved
sadilchamishka
dismissed stale reviews from ThaminduDilshan and shashimalcse
via
70758a6
AnuradhaSK
reviewed
Apr 26, 2024
...plication.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ApplicationMgtUtil.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Apr 26, 2024
| * @return The resolved URL from placeholders. | ||
| * @throws URLBuilderException If any error occurs when building absolute public url without path. | ||
| */ | ||
| public static String resolveOriginUrlFromPlaceholdersPortalApps(String absoluteUrl, String appName) |
There was a problem hiding this comment.
Let's make this a generic method, by overloading resolveOriginUrlFromPlaceholders with absoluteUrl and appName
There was a problem hiding this comment.
Fixed by - 9e6fadc
AnuradhaSK
approved these changes
Apr 26, 2024
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8844263458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject