Add attribute name format property into SAML configurations #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the current implementation, the attribute statement of the SAML assertion sends each attribute's
NameFormat
as theBasic
type. However, according to the SAML specification, there are two different types ofNameFormat
as follows:urn:oasis:names:tc:SAML:2.0:attrname-format:uri
- if the name format is uri, then the attribute name should be in the uri format. A sample attribute is given below.urn:oasis:names:tc:SAML:2.0:attrname-format:basic
- If the attribute name format is basic, then the attribute name will be a string which belongs to the type xs:Name type [1]. The attribute name should be a simple plain strings.This PR introduces support for configuring the
NameFormat
using one of the three values mentioned above through UI, SOAP and REST APIs. The selectedNameFormat
will then be displayed for each attribute in theAttributeStatement
of the SAML assertion. However, to maintain backward compatibility,urn:oasis:names:tc:SAML:2.0:attrname-format:basic
will remain the defaultNameFormat
, even when URI attribute names are by default used in IS.<>
Related Issue
Related PRs
[1] https://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf