-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing the federated token in oidc authentication #2402
Conversation
cc28fc9
to
0bfd7bf
Compare
...bon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/model/FederatedTokenDO.java
Outdated
Show resolved
Hide resolved
...ndpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java
Outdated
Show resolved
Hide resolved
...ndpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/oauth2/token/handlers/response/FederatedTokenResponseHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's run integrations tests before merging.
This PR is failing since the dependency PR |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8227739760
Proposed changes in this pull request
When should this PR be merged
Unit tests should be there.
Following PRs are merged and version bumped.
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation