✨ Implement read-only and write-only fields #28

paul1999 · 2023-12-07T11:52:02Z

Fixes #27

wrenger · 2023-12-10T12:19:56Z

Hi @paul1999 thanks a lot for your contribution.
I finally have the time to look into this and review your changes.

wrenger

Your additions are quite excellent, not much to criticize. The first three comments are minor style suggestions (that are rather optional). Though, the last one about a proper error for invalid access values might be more important.

src/lib.rs

This is useful when implement drivers for memory mapped I/O. Some of the device registers should only be read/written, but not the opposite. Fixes wrenger#27

wrenger · 2023-12-10T23:31:58Z

Thanks, I merged it and released it with 0.5.6.

paul1999 force-pushed the access-mode branch from 422db81 to a906eeb Compare December 7, 2023 11:53

wrenger reviewed Dec 10, 2023

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

wrenger self-assigned this Dec 10, 2023

paul1999 added 3 commits December 10, 2023 20:00

✨ Implement read-only and write-only fields

f33d775

This is useful when implement drivers for memory mapped I/O. Some of the device registers should only be read/written, but not the opposite. Fixes wrenger#27

✅ Add tests for access field on bit attribute

59e2ba6

📝 Add documentation for field access mode

4af40a0

paul1999 force-pushed the access-mode branch from a906eeb to 4af40a0 Compare December 10, 2023 19:01

wrenger merged commit 9b2a94b into wrenger:main Dec 10, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Implement read-only and write-only fields #28

✨ Implement read-only and write-only fields #28

paul1999 commented Dec 7, 2023

wrenger commented Dec 10, 2023

wrenger left a comment

wrenger commented Dec 10, 2023

✨ Implement read-only and write-only fields #28

✨ Implement read-only and write-only fields #28

Conversation

paul1999 commented Dec 7, 2023

wrenger commented Dec 10, 2023

wrenger left a comment

Choose a reason for hiding this comment

wrenger commented Dec 10, 2023