This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Jarius - telemetry update (4/5/2022) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 28, 2022 02:34
added new fields
Telemetry Works for updating the following: - relative wind - pitch and roll (updates very slowly) - magnetic heading (current heading)
tnurse18
reviewed
Apr 6, 2022
| @@ -1,4 +1,11 @@ | |||
| const socket = io(); // socket initialization | |||
| //const socket = io("http://localhost:3000/", { transports: ['polling', 'flashsocket'] }); // socket initialization | |||
There was a problem hiding this comment.
We should keep this. This way we won't need to manually change this IP address every time we use a different one.
There was a problem hiding this comment.
This will be re-implemented using localhost
public/index.html
Outdated
|
|
||
| <link rel="stylesheet" href="css/dashboard.css"> | ||
| <link rel="stylesheet" href="css/simple-grid.min.css"> | ||
| <link rel="stylesheet" href="css/foundation.css"> | ||
| <link rel="shortcut icon" href="/assets/favicon.ico" type="image/x-icon"> | ||
| <link rel="icon" href="/assets/favicon.ico" type="image/x-icon"> | ||
| <link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon"> |
There was a problem hiding this comment.
For a relative path you should be able to do the following where applicable:
Suggested change
| <link rel="shortcut icon" href="../public/assets/favicon.ico" type="image/x-icon"> | |
| <link rel="shortcut icon" href="assets/favicon.ico" type="image/x-icon"> |
| <script type="text/javascript" src="/js/dependencies/d3.min.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="/js/dependencies/d3gauge.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="/js/dependencies/FileSaver.min.js" charset="utf-8"></script> | ||
| <script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script> |
There was a problem hiding this comment.
Suggested change
| <script type="text/javascript" src="./js/dependencies/socket.io.min.js"></script> | |
| <script type="text/javascript" src="js/dependencies/socket.io.min.js"></script> |
public/index.html
Outdated
| <text>Trim Battery:</text> | ||
| </div> | ||
| <div class="values"> | ||
| <text id="voltage">14.8 V</text> |
There was a problem hiding this comment.
Since we don't actually get a voltage value right now, it might be nice to have an icon or graphic here instead
public/index.html
Outdated
| <text id="voltage">14.8 V</text> | ||
| <text id="hull-status">Battery Low.</text> | ||
| <text id="btstatus">OK</text> | ||
| <text id="trimtab-voltage">5.0 V</text> |
There was a problem hiding this comment.
We don't actually get a voltage from the trim tab controller. We get a percentage.
There was a problem hiding this comment.
Changing representation to a % symbol in the next commit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard WORKS for
---- MORE UPDATES TBD